linux-kernel - Re: [PATCH] cpufreq: imx6q: Only disabling 792MHz OPP for i.MX6ULL types below 792MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <188c5e1cddc05f9bd44510e0a4f988df@denx.de>
Date:   Tue, 07 Nov 2023 14:47:35 -0300
From:   Fabio Estevam <festevam@...x.de>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Sébastien Szymanski 
        <sebastien.szymanski@...adeus.com>, Stefan Agner <stefan@...er.ch>,
        Shawn Guo <shawnguo@...nel.org>, Marek Vasut <marex@...x.de>,
        NXP Linux Team <linux-imx@....com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: imx6q: Only disabling 792MHz OPP for i.MX6ULL
 types below 792MHz

Hi Christoph,

Thanks for your patch.

On 07/11/2023 13:31, Christoph Niedermaier wrote:
> For a 900MHz i.MX6ULL CPU the 792MHz OPP is disabled. There is no
> convincing reason to disable this OPP. If a CPU can run at 900MHz,
> it should also be able to cope with 792MHz. Looking at the voltage
> level of 792MHz in [1] (page 24, table 10. "Operating Ranges") the
> current defined OPP is above the minimum. So the voltage level
> shouldn't be a problem. Although in [2] (page 24, table 10.
> "Operating Ranges") 792MHz isn't mentioned there isn't note that
> 792MHz OPP isn't allowed. Change it to only disable 792MHz OPP for

I find this part:

"792MHz isn't mentioned there isn't note that 792MHz OPP isn't allowed."

a bit confusing.

Maybe:

"However in [2] (page 24, table 10. "Operating Ranges"), it is not 
mentioned that 792MHz OPP isn't allowed."


> [1] https://www.nxp.com/docs/en/data-sheet/IMX6ULLIEC.pdf
> [2] https://www.nxp.com/docs/en/data-sheet/IMX6ULLCEC.pdf
> 
> Signed-off-by: Christoph Niedermaier <cniedermaier@...electronics.com>
> Reviewed-by: Marek Vasut <marex@...x.de>

I think it is worth adding a Fixes tag so that this fix could be 
backported
to stable kernels.

Reviewed-by: Fabio Estevam <festevam@...x.de>

Thanks