linux-kernel - Re: [PATCH 2/6] mm: memory: use a folio in validate_page_before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3dc3bf8-28e2-4215-738a-7150f8165737@oracle.com>
Date:   Tue, 7 Nov 2023 10:17:53 -0800
From:   Sidhartha Kumar <sidhartha.kumar@...cle.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Matthew Wilcox <willy@...radead.org>,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH 2/6] mm: memory: use a folio in
 validate_page_before_insert()

On 11/7/23 5:52 AM, Kefeng Wang wrote:
> Use a folio in validate_page_before_insert() to save two
> compound_head() calls.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>   mm/memory.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 1f18ed4a5497..b1bff4d245da 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1836,9 +1836,12 @@ pte_t *__get_locked_pte(struct mm_struct *mm, unsigned long addr,
>   
>   static int validate_page_before_insert(struct page *page)
>   {
> -	if (PageAnon(page) || PageSlab(page) || page_has_type(page))
> +	struct folio *folio = page_folio(page);
> +
> +	if (folio_test_anon(folio) || folio_test_slab(folio) ||
> +	    page_has_type(page))
>   		return -EINVAL;
> -	flush_dcache_page(page);
> +	flush_dcache_folio(folio);
>   	return 0;
>   }
>   
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>