linux-kernel - Re: [GIT PULL] overlayfs update for 6.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxhfanssN=GdxfC7ANG=it=VMJz549z0zZ5uEGULeGK6yA@mail.gmail.com>
Date:   Tue, 7 Nov 2023 23:07:29 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Miklos Szeredi <miklos@...redi.hu>,
        Christian Brauner <brauner@...nel.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-unionfs@...r.kernel.org
Subject: Re: [GIT PULL] overlayfs update for 6.7

On Tue, Nov 7, 2023 at 9:54 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sun, 5 Nov 2023 at 22:50, Amir Goldstein <amir73il@...il.com> wrote:
> >
> > - Overlayfs aio cleanups and fixes [1]
> >
> > - Overlayfs lock ordering changes [2]
> >
> > - Add support for nesting overlayfs private xattrs [3]
> >
> > - Add new mount options for appending lowerdirs [4]
> >
> > [1] https://lore.kernel.org/r/20230912173653.3317828-1-amir73il@gmail.com/
> > [2] https://lore.kernel.org/r/20230816152334.924960-1-amir73il@gmail.com/
> > [3] https://lore.kernel.org/r/cover.1694512044.git.alexl@redhat.com/
> > [4] https://lore.kernel.org/r/20231030120419.478228-1-amir73il@gmail.com/
>
> *Please* don't make me have to follow links just to see basic details.
>

No problem.

> Merge messages should stand on their own, not just point to "look,
> here are the details in our lore archives". Yes, even when having
> internet access is much more common, there are situations where it's
> not there or is slow. Or maybe lore has issues. Or maybe people just
> don't want to switch to a browser to look up details that may or may
> not be relevant to them.
>
> I copied the relevant stuff into my merge, but please don't make me do
> this next time.

Thanks for adding this information - I certainly didn't intend for
you to do this extra work.

> Just give me a merge message with the details spelled
> out, not some link to a cover letter for a patch series.
>

OK.

To explain the reason why I add those links:

A while ago, I was helping out with backporting many xfs patches
to stable tree after a long period of neglection.

I found the need to point back from fix commits to patch series
because the cover letters often contained important information
relevant for backporting and testing.

So I hacked up a small b4 gadget to disassemble a PR
into lore links to patch series:
(*) you don't have to follow this link unless you are curious ;)
https://github.com/amir73il/b4/commit/f5966362a524182206d5c5e8a4f96fba5d4c92ca

At the time, I had wished that the links to the patch series
composing the PR would have been in the PR email
(doesn't really matter if you take them into the merge commit).

This is why I included this "debug info" of the PR.
Next time, if I include the lore links, I will separate
them to a different section, so it is clear that I do not
require them to be in the merge commit.

Thanks,
Amir.