linux-kernel - Re: [RFC PATCH 14/86] Revert "preempt/dynamic: Fix setup_preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231107182030.0dfc4e78@gandalf.local.home>
Date:   Tue, 7 Nov 2023 18:20:30 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ankur Arora <ankur.a.arora@...cle.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org, torvalds@...ux-foundation.org,
        paulmck@...nel.org, linux-mm@...ck.org, x86@...nel.org,
        akpm@...ux-foundation.org, luto@...nel.org, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        willy@...radead.org, mgorman@...e.de, jon.grimm@....com,
        bharata@....com, raghavendra.kt@....com,
        boris.ostrovsky@...cle.com, konrad.wilk@...cle.com,
        jgross@...e.com, andrew.cooper3@...rix.com, mingo@...nel.org,
        bristot@...nel.org, mathieu.desnoyers@...icios.com,
        geert@...ux-m68k.org, glaubitz@...sik.fu-berlin.de,
        anton.ivanov@...bridgegreys.com, mattst88@...il.com,
        krypton@...ich-teichert.org, David.Laight@...LAB.COM,
        richard@....at, mjguzik@...il.com
Subject: Re: [RFC PATCH 14/86] Revert "preempt/dynamic: Fix
 setup_preempt_mode() return value"

On Tue,  7 Nov 2023 13:57:00 -0800
Ankur Arora <ankur.a.arora@...cle.com> wrote:

> This reverts commit 9ed20bafc85806ca6c97c9128cec46c3ef80ae86.

Note, it's better to just do a big revert of related code than to have to
revert every individual commit.

You can do one big commit that states:

This reverts commits:

  ....

And list the commits.

That is, for commits that affect a single file, do not cherry-pick commits
to remove, just remove them all in one go.

-- Steve


> 
> Signed-off-by: Ankur Arora <ankur.a.arora@...cle.com>
> ---
>  kernel/sched/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f8bbddd729db..50e1133cacc9 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -7062,11 +7062,11 @@ static int __init setup_preempt_mode(char *str)
>  	int mode = sched_dynamic_mode(str);
>  	if (mode < 0) {
>  		pr_warn("Dynamic Preempt: unsupported mode: %s\n", str);
> -		return 0;
> +		return 1;
>  	}
>  
>  	sched_dynamic_update(mode);
> -	return 1;
> +	return 0;
>  }
>  __setup("preempt=", setup_preempt_mode);
>