linux-kernel - Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUrO5aRPUux_QchV@debian.me>
Date:   Wed, 8 Nov 2023 06:57:25 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Hunter Chasens <hunter.chasens18@....edu>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Linux Documentation <linux-doc@...r.kernel.org>,
        Linux DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux AMDGPU <amd-gfx@...ts.freedesktop.org>, daniel@...ll.ch,
        airlied@...il.com, Xinhui.Pan@....com, christian.koenig@....com,
        alexander.deucher@....com, Lijo Lazar <lijo.lazar@....com>
Subject: Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation
 warning

On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
> 
> Signed-off-by: Hunter Chasens <hunter.chasens18@....edu>

Nit: Whenever a reviewer has offered a Reviewed-by: or Acked-by: trailer,
you should include it in the next reroll unless there is substantial changes
in the reroll.

> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
>   * Reading back the files will show you the available power levels within
>   * the power state and the clock information for those levels. If deep sleep is
>   * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - *	S: 19Mhz *
> - *	0: 615Mhz
> - *	1: 800Mhz
> - *	2: 888Mhz
> - *	3: 1000Mhz
> + * E.g., ::
> + *
> + *  S: 19Mhz *
> + *  0: 615Mhz
> + *  1: 800Mhz
> + *  2: 888Mhz
> + *  3: 1000Mhz
>   *
>   *
>   * To manually adjust these states, first select manual using

Anyway, LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)