[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d44ce895-6b88-4db1-9cd4-5913c82a8244@kernel.org>
Date: Tue, 7 Nov 2023 08:28:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: gabriel.fernandez@...s.st.com,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: st: add rcc support in stm32mp251
On 06/11/2023 15:18, gabriel.fernandez@...s.st.com wrote:
> From: Gabriel Fernandez <gabriel.fernandez@...s.st.com>
>
> Add RCC support used for to manage clocks and resets on stm32mp251.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@...s.st.com>
> ---
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 59 ++++++++++++++------------
> 1 file changed, 31 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 124403f5f1f4..698d0f68b98d 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -3,7 +3,9 @@
> * Copyright (C) STMicroelectronics 2023 - All Rights Reserved
> * Author: Alexandre Torgue <alexandre.torgue@...s.st.com> for STMicroelectronics.
> */
> +#include <dt-bindings/clock/stm32mp25-clks.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/reset/stm32mp25-resets.h>
>
> / {
> #address-cells = <2>;
> @@ -35,22 +37,10 @@ arm_wdt: watchdog {
> };
>
> clocks {
> - ck_flexgen_08: ck-flexgen-08 {
> + clk_rcbsec: clk-rcbsec {
> #clock-cells = <0>;
> compatible = "fixed-clock";
> - clock-frequency = <100000000>;
> - };
> -
> - ck_flexgen_51: ck-flexgen-51 {
> - #clock-cells = <0>;
> - compatible = "fixed-clock";
> - clock-frequency = <200000000>;
> - };
> -
> - ck_icn_ls_mcu: ck-icn-ls-mcu {
> - #clock-cells = <0>;
> - compatible = "fixed-clock";
> - clock-frequency = <200000000>;
> + clock-frequency = <64000000>;
> };
> };
>
> @@ -122,7 +112,7 @@ usart2: serial@...e0000 {
> compatible = "st,stm32h7-uart";
> reg = <0x400e0000 0x400>;
> interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ck_flexgen_08>;
> + clocks = <&rcc CK_KER_USART2>;
> status = "disabled";
> };
>
> @@ -131,7 +121,7 @@ sdmmc1: mmc@...20000 {
> arm,primecell-periphid = <0x00353180>;
> reg = <0x48220000 0x400>, <0x44230400 0x8>;
> interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ck_flexgen_51>;
> + clocks = <&rcc CK_KER_SDMMC1 >;
> clock-names = "apb_pclk";
> cap-sd-highspeed;
> cap-mmc-highspeed;
> @@ -140,6 +130,19 @@ sdmmc1: mmc@...20000 {
> };
> };
>
> + rcc: rcc@...00000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
Powered by blists - more mailing lists