linux-kernel - Re: [PATCH 08/21] binder: keep vma addresses type as unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231107090813.258015-1-aliceryhl@google.com>
Date:   Tue,  7 Nov 2023 09:08:13 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     Carlos Llamas <cmllamas@...gle.com>
Cc:     "Arve Hjønnevåg" <arve@...roid.com>,
        Christian Brauner <brauner@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org,
        Martijn Coenen <maco@...roid.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Todd Kjos <tkjos@...roid.com>
Subject: Re: [PATCH 08/21] binder: keep vma addresses type as unsigned long

Carlos Llamas <cmllamas@...gle.com> writes:
> -	seq_printf(m, " size %zd:%zd data %pK\n",
> +	seq_printf(m, " size %zd:%zd data %lx\n",
>  		   buffer->data_size, buffer->offsets_size,
>  		   buffer->user_data);

This changes all of the print operations to use %lx instead of %pK,
which means that the addresses are no longer being hidden when using
kptr_restrict.

Since the pointers are all userspace pointers, it's not clear to me what
the consequences of this are. However, I'd like to confirm whether this
is an intentional change?

And if so, maybe it should use %px instead?

(Everything else in this change LGTM.)

Alice