linux-kernel - RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36f2d12934d64a278f2c0313cbd01abc@huawei.com>
Date:   Tue, 7 Nov 2023 09:38:16 +0000
From:   Shiju Jose <shiju.jose@...wei.com>
To:     Ira Weiny <ira.weiny@...el.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>
CC:     Dan Williams <dan.j.williams@...el.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        Yazen Ghannam <yazen.ghannam@....com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Dave Jiang <dave.jiang@...el.com>,
        Alison Schofield <alison.schofield@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>
Subject: RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known
 events

Hi Ira,

>-----Original Message-----
>From: Ira Weiny <ira.weiny@...el.com>
>Sent: 06 November 2023 22:06
>To: Shiju Jose <shiju.jose@...wei.com>; Jonathan Cameron
><jonathan.cameron@...wei.com>; Ira Weiny <ira.weiny@...el.com>
>Cc: Dan Williams <dan.j.williams@...el.com>; Smita Koralahalli
><Smita.KoralahalliChannabasappa@....com>; Yazen Ghannam
><yazen.ghannam@....com>; Davidlohr Bueso <dave@...olabs.net>; Dave
>Jiang <dave.jiang@...el.com>; Alison Schofield <alison.schofield@...el.com>;
>Vishal Verma <vishal.l.verma@...el.com>; Ard Biesheuvel <ardb@...nel.org>;
>linux-efi@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
>cxl@...r.kernel.org
>Subject: RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known
>events
>
>Shiju Jose wrote:
>>
>>
>> >-----Original Message-----
>> >From: Jonathan Cameron <jonathan.cameron@...wei.com>
>> >Sent: 03 November 2023 14:28
>> >To: Ira Weiny <ira.weiny@...el.com>
>> >Cc: Dan Williams <dan.j.williams@...el.com>; Smita Koralahalli
>> ><Smita.KoralahalliChannabasappa@....com>; Yazen Ghannam
>> ><yazen.ghannam@....com>; Davidlohr Bueso <dave@...olabs.net>; Dave
>> >Jiang <dave.jiang@...el.com>; Alison Schofield
>> ><alison.schofield@...el.com>; Vishal Verma
>> ><vishal.l.verma@...el.com>; Ard Biesheuvel <ardb@...nel.org>;
>> >linux-efi@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
>> >cxl@...r.kernel.org; Shiju Jose <shiju.jose@...wei.com>
>> >Subject: Re: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event
>> >trace known events
>> >
>> >On Wed, 01 Nov 2023 14:11:18 -0700
>> >Ira Weiny <ira.weiny@...el.com> wrote:
>> >
>> >> The uuid printed in the well known events is redundant.  The uuid
>> >> defines what the event was.
>> >>
>> >> Remove the uuid from the known events and only report it in the
>> >> generic event as it remains informative there.
>> >>
>> >> Reviewed-by: Davidlohr Bueso <dave@...olabs.net>
>> >> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
>> >> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
>> >
>> >Removing the print is fine, but look like this also removes the
>> >actual trace point field.  That's userspace ABI.  Expanding it is
>> >fine, but taking fields away is more problematic.
>> >
>> >Are we sure we don't break anyone?  Shiju, will rasdaemon be fine
>> >with this change?
>>
>> The field hdr_uuid is removed from the common CXL_EVT_TP_entry shared
>> by the trace events cxl_generic_event, cxl_general_media, cxl_dram and
>cxl_memory_module .
>> rasdaemon will break because of this while processing these trace
>> events and also affects the corresponding error records in the SQLite data
>base.
>> Rasdaemon needs update to avoid this.
>>
>
>Ok we can leave the uuid field in easy enough.
>
>But does rasdaemon use the value of the field for anything?  In other words does
>CPER record processing need to generate a proper UUID value?
No. Presently used for logging purpose only in the rasdaemon.

>
>Ira

Thanks,
Shiju