linux-kernel - Re: [PATCH v1] USB: dwc3: only call usb_phy_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <GV0P278MB05896EF2725F208A93C0294FE8A9A@GV0P278MB0589.CHEP278.PROD.OUTLOOK.COM>
Date:   Tue, 7 Nov 2023 09:42:29 +0000
From:   Stefan Eichenberger <stefan.eichenberger@...adex.com>
To:     Johan Hovold <johan@...nel.org>
CC:     Francesco Dolcini <francesco@...cini.it>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1] USB: dwc3: only call usb_phy_set_suspend in
 suspend/resume

> From: Johan Hovold <johan@...nel.org>
> >
> > We have an external hub that we want to turn off when the system goes
> > into suspend. For the i.MX8MM we use the phy-generic driver to achieve
> > this. When I saw that the dwc3 driver would support the phy-generic via
> > usb-phy, I thought we could use the same approach for the i.MX8MP and,
> > in the future, the AM62. Maybe I misunderstood, would the right solution
> > be to add a suspend function to the fsl,imx8mp-usb-phy driver and use
> > vbus instead? But what would we do for the AM62, as it doesn't have a
> > phy driver if I'm not mistaken.
>
> That's not how the phy driver is supposed be used, and for on-board hubs
> we now have:
>
>         drivers/usb/misc/onboard_usb_hub.c
>
> Have you tried using that one instead?

Thanks for the tip. I have now tested it and it seems to work for our
use case. I will see if I can use it for the other devices as well.

Best regards,
Stefan