linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sm8250: correct Soundwire node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4256787-5f1e-4d19-9dbc-223504e55cd2@linaro.org>
Date:   Tue, 7 Nov 2023 11:22:36 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8250: correct Soundwire node name

On 07/11/2023 11:21, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
> 
>    sm8250-xiaomi-elish-boe.dtb: soundwire-controller@...0000: $nodename:0: 'soundwire-controller@...0000' does not match '^soundwire(@.*)?$'
> 
> Reported-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index da71de5e1a80..e18a18a9e767 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2557,7 +2557,7 @@ wsamacro: codec@...0000 {
>   			status = "disabled";
>   		};
>   
> -		swr0: soundwire-controller@...0000 {
> +		swr0: soundwire@...0000 {
>   			reg = <0 0x03250000 0 0x2000>;
>   			compatible = "qcom,soundwire-v1.5.1";
>   			interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2623,7 +2623,7 @@ rxmacro: rxmacro@...0000 {
>   			#sound-dai-cells = <1>;
>   		};
>   
> -		swr1: soundwire-controller@...0000 {
> +		swr1: soundwire@...0000 {
>   			reg = <0 0x03210000 0 0x2000>;
>   			compatible = "qcom,soundwire-v1.5.1";
>   			status = "disabled";
> @@ -2670,7 +2670,7 @@ txmacro: txmacro@...0000 {
>   		};
>   
>   		/* tx macro */
> -		swr2: soundwire-controller@...0000 {
> +		swr2: soundwire@...0000 {
>   			reg = <0 0x03230000 0 0x2000>;
>   			compatible = "qcom,soundwire-v1.5.1";
>   			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>