linux-kernel - Re: [RFC 2/8] usb: dwc3: core: Register vendor hooks for dwc3-qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f94ca738-476c-4664-a8f1-e3ef3ac8220a@linaro.org>
Date:   Tue, 7 Nov 2023 10:41:13 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-usb@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        quic_ppratap@...cinc.com, quic_jackp@...cinc.com,
        quic_wcheng@...cinc.com, Andy Gross <agross@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [RFC 2/8] usb: dwc3: core: Register vendor hooks for dwc3-qcom

On 07/11/2023 08:33, Krishna Kurapati PSSNV wrote:
> 
> 
> On 11/4/2023 10:32 PM, Krishna Kurapati PSSNV wrote:
>>>
>>> Are you saying to you require/rely on both of these series being 
>>> applied first ?
>>>
>>> [1]: 
>>> https://lore.kernel.org/all/af60c05b-4a0f-51b8-486a-1fc601602515@quicinc.com/
>>> [2]: 
>>> https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/
>>>
>>> Must be, nothing applies for me in this series.
>>
>> The first one is not a patch. It is just a discussion thread I started 
>> to get community's opinion before on disconnect interrupt handling. 
>> The current series is based on top of [2] made by Bjorn (as you 
>> already found out) and as I mentioned in cover letter of my series.
>>
> 
> Hi Bryan,
> 
>    Are you able to apply the series after including Bjorn's patches ? 
> Also can you confirm if the comments provided to your queries on [1] are 
> proper and if you have any other comments w.r.t probe deferral.
> 
> [1]: 
> https://lore.kernel.org/all/e700133b-58f7-4a4d-8e5c-0d04441b789b@linaro.org/
> 
> Regards,
> Krishna,

I wonder could you give a base SHA to apply the various series on ?

Your referenced precursor doesn't apply to usb-next

deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ b4 shazam 
20231016-dwc3-refactor-v1-0-ab4a84165470@...cinc.com
Grabbing thread from 
lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@...cinc.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 27 messages in the thread
Checking attestation on all messages, may take a moment...
---
   [PATCH 1/12] dt-bindings: usb: qcom,dwc3: Add qcom,sc8180x-dwc3
   [PATCH 2/12] usb: dwc3: qcom: Rename dwc3 platform_device reference
     + Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
   [PATCH 3/12] usb: dwc3: qcom: Merge resources from urs_usb device
   [PATCH 4/12] usb: dwc3: Expose core driver as library
   [PATCH 5/12] usb: dwc3: Override end of dwc3 memory resource
     + Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
   [PATCH 6/12] usb: dwc3: qcom: Add dwc3 core reference in driver state
   [PATCH 7/12] usb: dwc3: qcom: Instantiate dwc3 core directly
   [PATCH 8/12] usb: dwc3: qcom: Inline the qscratch constants
     + Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
   [PATCH 9/12] dt-bindings: usb: qcom,dwc3: Rename to "glue"
     + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
   [PATCH 10/12] dt-bindings: usb: qcom,dwc3: Introduce flattened 
qcom,dwc3 binding
   [PATCH 11/12] usb: dwc3: qcom: Flatten the Qualcomm dwc3 binding and 
implementation
   [PATCH 12/12] arm64: dts: qcom: sc8180x: flatten usb_sec node
   ---
   ✗ No key: ed25519/quic_bjorande@...cinc.com
   ---
   NOTE: install dkimpy for DKIM signature verification
---
Total patches: 12
---
  Base: using specified base-commit 4d0515b235dec789578d135a5db586b25c5870cb
Applying: dt-bindings: usb: qcom,dwc3: Add qcom,sc8180x-dwc3
Patch failed at 0001 dt-bindings: usb: qcom,dwc3: Add qcom,sc8180x-dwc3
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: Documentation/devicetree/bindings/usb/qcom,dwc3.yaml:29
error: Documentation/devicetree/bindings/usb/qcom,dwc3.yaml: patch does 
not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git diff
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --skip
Applying: usb: dwc3: qcom: Rename dwc3 platform_device reference
error: patch failed: drivers/usb/dwc3/dwc3-qcom.c:67
error: drivers/usb/dwc3/dwc3-qcom.c: patch does not apply
Patch failed at 0002 usb: dwc3: qcom: Rename dwc3 platform_device reference
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --skip
Applying: usb: dwc3: qcom: Merge resources from urs_usb device
error: patch failed: drivers/usb/dwc3/dwc3-qcom.c:68
error: drivers/usb/dwc3/dwc3-qcom.c: patch does not apply
Patch failed at 0003 usb: dwc3: qcom: Merge resources from urs_usb device
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --skip
Applying: usb: dwc3: Expose core driver as library
error: patch failed: drivers/usb/dwc3/core.c:1876
error: drivers/usb/dwc3/core.c: patch does not apply
error: patch failed: drivers/usb/dwc3/core.h:1568
error: drivers/usb/dwc3/core.h: patch does not apply
Patch failed at 0004 usb: dwc3: Expose core driver as library
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --skip
Applying: usb: dwc3: Override end of dwc3 memory resource
error: patch failed: drivers/usb/dwc3/core.c:1908
error: drivers/usb/dwc3/core.c: patch does not apply
Patch failed at 0005 usb: dwc3: Override end of dwc3 memory resource
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --skip
Applying: usb: dwc3: qcom: Add dwc3 core reference in driver state
error: patch failed: drivers/usb/dwc3/dwc3-qcom.c:67
error: drivers/usb/dwc3/dwc3-qcom.c: patch does not apply
Patch failed at 0006 usb: dwc3: qcom: Add dwc3 core reference in driver 
state
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
deckard@...ittarius-a:~/Development/qualcomm/qlt-kernel$ git am --abort

---
bod