[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231107110327.GU8262@noisy.programming.kicks-ass.net>
Date: Tue, 7 Nov 2023 12:03:27 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Abel Wu <wuyun.abel@...edance.com>
Cc: Ingo Molnar <mingo@...nel.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Valentin Schneider <valentin.schneider@....com>,
Barry Song <21cnbao@...il.com>,
Benjamin Segall <bsegall@...gle.com>,
Chen Yu <yu.c.chen@...el.com>,
Daniel Jordan <daniel.m.jordan@...cle.com>,
"Gautham R . Shenoy" <gautham.shenoy@....com>,
Joel Fernandes <joel@...lfernandes.org>,
K Prateek Nayak <kprateek.nayak@....com>,
Mike Galbraith <efault@....de>,
Qais Yousef <qyousef@...alina.io>,
Tim Chen <tim.c.chen@...ux.intel.com>,
Yicong Yang <yangyicong@...wei.com>,
Youssef Esmat <youssefesmat@...omium.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] sched/eevdf: Sort the rbtree by virtual deadline
On Tue, Nov 07, 2023 at 05:05:08PM +0800, Abel Wu wrote:
> Sort the task timeline by virtual deadline and keep the min_vruntime
> in the augmented tree, so we can avoid doubling the worst case cost
> and make full use of the cached leftmost node to enable O(1) fastpath
> picking in next patch.
Another very good patch, just a note:
> This patch also cleans up the unused max_vruntime() and adjusts pos
> for some functions.
There's this thing about saying 'this patch' in Changelogs, per
definition the Changelog is about 'this patch' so saying it is a bit
redundant.
It even gets mentioned in the Documentation on submitting patches
somewhere.
But what I care about more is this patch doing extra unrelated things,
this should be split out.
Powered by blists - more mailing lists