linux-kernel - Re: [PATCH v1 0/3] TPS65224 PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231107113740.1034738-1-sirisha.gairuboina@Ltts.com>
Date:   Tue,  7 Nov 2023 17:07:40 +0530
From:   Gairuboina Sirisha <sirisha.gairuboina@...s.com>
To:     jpanis@...libre.com
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        linux-kernel@...r.kernel.org, sirisha.gairuboina@...s.com,
        Gairuboina Sirisha <sirisha.gairuboina@...s.com>
Subject: Re: [PATCH v1 0/3] TPS65224 PMIC driver

From: Gairuboina Sirisha <sirisha.gairuboina@...s.com>

> On 10/26/23 15:32, Gairuboina Sirisha wrote:
> > Added support for TPS65224 PMIC in linux.
> > This patch set includes driver for core, i2c and pfsm.
> > The driver was tested on TI's custom AM62A EVM.
> >
> > Gairuboina Sirisha (3):
> >    drivers: mfd: Add support for TPS65224
> >    drivers: mfd: Add support for TPS65224 i2c driver
> >    drivers: misc: Add support for TPS65224 pfsm driver
> >
> >   drivers/mfd/Kconfig                |  19 +
> >   drivers/mfd/Makefile               |   2 +
> >   drivers/mfd/tps65224-core.c        | 291 ++++++++++++
> >   drivers/mfd/tps65224-i2c.c         | 245 ++++++++++
> >   drivers/misc/Kconfig               |  12 +
> >   drivers/misc/Makefile              |   1 +
> >   drivers/misc/tps65224-pfsm.c       | 290 ++++++++++++
> >   include/linux/mfd/tps65224.h       | 735 +++++++++++++++++++++++++++++
> >   include/uapi/linux/tps65224_pfsm.h |  36 ++
> >   9 files changed, 1631 insertions(+)
> >   create mode 100644 drivers/mfd/tps65224-core.c
> >   create mode 100644 drivers/mfd/tps65224-i2c.c
> >   create mode 100644 drivers/misc/tps65224-pfsm.c
> >   create mode 100644 include/linux/mfd/tps65224.h
> >   create mode 100644 include/uapi/linux/tps65224_pfsm.h
>
> Hi Sirisha,
>
> These drivers strongly look like TPS6594 drivers.
>
> Instead of submitting new drivers, you should consider reusing and
> modifying the existing ones for TPS6594. You might add your new 'compatible'
> entry ("ti,tps65224-q1") in TPS6594 dt-bindings (see 'ti,tps6594.yaml' file)
> to identify your TPS65224 PMIC. This new 'compatible' would also be added
> in the existing 'tps6594_i2c_of_match_table'. You can have a look at
> 'tps->chip_id' in 'tps6594-core.c' and see how we use it to deal with slight
> differences between different PMIC IDs.

Thanks for the response. While the TPS65224 drivers follow the format and
structure of TPS6594, the register maps, masks, and ADC feature differ.
The two PMICs have overlapping features but TPS65224 is not treated as a subset.
TPS65224 is treated as a separate and independent driver instead of adding
compatibility to the existing TPS6594 driver that would then support 3 PMICS.
This separation will better support our differing PMICs.

Thanks & Regards,
Sirisha G.