linux-kernel - Re: [PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f4666c4-ad5d-bdc1-1d86-ddf5fc824a12@nuvoton.com>
Date:   Tue, 7 Nov 2023 10:32:45 +0800
From:   AS50 WTLi <WTLI@...oton.com>
To:     Rob Herring <robh@...nel.org>
Cc:     broonie@...nel.org, lgirdwood@...il.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, conor+dt@...nel.org,
        YHCHuang@...oton.com, KCHSU0@...oton.com, CTLIN0@...oton.com,
        SJLIN0@...oton.com, scott6986@...il.com, supercraig0719@...il.com,
        dardar923@...il.com
Subject: Re: [PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate


On 11/6/2023 10:41 PM, Rob Herring wrote:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> On Wed, Nov 01, 2023 at 02:35:13PM +0800, Seven Lee wrote:
>> Add input with DMIC slew rate controls
>>
>> Signed-off-by: Seven Lee <wtli@...oton.com>
>> ---
>>   .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> index 3e54abd4ca74..48c389276a15 100644
>> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> @@ -89,6 +89,13 @@ properties:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       default: 3072000
>>
>> +  nuvoton,dmic-slew-rate:
>> +    description: The range 0 to 7 represents the speed of DMIC slew rate.
>> +        The lowest value 0 means the slowest rate and the highest value
>> +        7 means the fastest rate.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    default: 0
> Don't write constraints in prose:
>
> maximum: 7

okay, I will add maximum: 7 description. Thanks.

>
>> +
>>     nuvoton,left-input-single-end:
>>       description: Enable left input with single-ended settings if set.
>>           For the headset mic application, the single-ended control is
>> @@ -127,6 +134,7 @@ examples:
>>               nuvoton,jack-insert-debounce = <7>;
>>               nuvoton,jack-eject-debounce = <0>;
>>               nuvoton,dmic-clk-threshold = <3072000>;
>> +            nuvoton,dmic-slew-rate= <0>;
>>               #sound-dai-cells = <0>;
>>           };
>>       };
>> --
>> 2.25.1
>>
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.