linux-kernel - Re: (subset) [PATCH 06/22] [RESEND] stackleak: add declarations for global functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <169947044722.632596.1406506664231353344.b4-ty@chromium.org>
Date:   Wed,  8 Nov 2023 11:07:31 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: (subset) [PATCH 06/22] [RESEND] stackleak: add declarations for global functions

On Wed, 08 Nov 2023 13:58:27 +0100, Arnd Bergmann wrote:
> With -Wmissing-prototypes enabled, the stackleak code produces a couple of
> warnings that have no declarations because they are only called from assembler:
> 
> stackleak.c:127:25: error: no previous prototype for 'stackleak_erase' [-Werror=missing-prototypes]
> stackleak.c:139:25: error: no previous prototype for 'stackleak_erase_on_task_stack' [-Werror=missing-prototypes]
> stackleak.c:151:25: error: no previous prototype for 'stackleak_erase_off_task_stack' [-Werror=missing-prototypes]
> stackleak.c:159:49: error: no previous prototype for 'stackleak_track_stack' [-Werror=missing-prototypes]
> 
> [...]

Applied to for-next/hardening, thanks!

[06/22] stackleak: add declarations for global functions
        https://git.kernel.org/kees/c/65120498aaf8

Take care,

-- 
Kees Cook