linux-kernel - Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <e7753f82-c3de-48fc-955d-59773222aaa9@app.fastmail.com>
Date:   Wed, 08 Nov 2023 22:07:18 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Andrew Morton" <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org, "Matt Turner" <mattst88@...il.com>,
        "Vineet Gupta" <vgupta@...nel.org>,
        "Russell King" <linux@...linux.org.uk>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>, guoren <guoren@...nel.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Ard Biesheuvel" <ardb@...nel.org>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Greg Ungerer" <gerg@...ux-m68k.org>,
        "Michal Simek" <monstr@...str.eu>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Dinh Nguyen" <dinguyen@...nel.org>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Nicholas Piggin" <npiggin@...il.com>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Geoff Levand" <geoff@...radead.org>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "David S . Miller" <davem@...emloft.net>,
        "Andy Lutomirski" <luto@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, x86@...nel.org,
        "Helge Deller" <deller@....de>,
        "Sudip Mukherjee" <sudipm.mukherjee@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Timur Tabi" <timur@...nel.org>,
        "Kent Overstreet" <kent.overstreet@...ux.dev>,
        "David Woodhouse" <dwmw2@...radead.org>,
        "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
        "Anil S Keshavamurthy" <anil.s.keshavamurthy@...el.com>,
        "Kees Cook" <keescook@...omium.org>,
        "Vincenzo Frascino" <vincenzo.frascino@....com>,
        "Juri Lelli" <juri.lelli@...hat.com>,
        "Vincent Guittot" <vincent.guittot@...aro.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Nicolas Schier" <nicolas@...sle.eu>,
        "Alexander Viro" <viro@...iv.linux.org.uk>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-trace-kernel@...r.kernel.org,
        "linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
        loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, linux-parisc@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        "linux-bcachefs@...r.kernel.org" <linux-bcachefs@...r.kernel.org>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype

On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote:
>
> On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann <arnd@...nel.org> wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> Microblaze runs into a single -Wmissing-prototypes warning when that is
>> enabled:
>>
>> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for 'trap_init' [-Wmissing-prototypes]
>>
>> Include the right header to avoid this.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks for your patch!
>
>>  arch/alpha/kernel/traps.c      | 1 +
>>  arch/csky/include/asm/traps.h  | 2 --
>>  arch/csky/kernel/traps.c       | 1 +
>>  arch/m68k/coldfire/vectors.c   | 3 +--
>>  arch/m68k/coldfire/vectors.h   | 3 ---
>
> Ah, so this is where the m68k changes listed in the cover letter are
> hiding ;-)
>
>>  arch/microblaze/kernel/traps.c | 1 +
>>  arch/sparc/kernel/traps_32.c   | 1 +
>>  arch/sparc/kernel/traps_64.c   | 1 +
>>  arch/x86/include/asm/traps.h   | 1 -
>>  arch/x86/kernel/traps.c        | 1 +
>>  10 files changed, 7 insertions(+), 8 deletions(-)
>>  delete mode 100644 arch/m68k/coldfire/vectors.h
>
> Obviously the non-microblaze changes should be spun off in separate
> patches.

I messed up one of my rebases here and accidentally sent
the wrong changelog text. My intention was to have the
combined patch but with this text:

    arch: include linux/cpu.h for trap_init() prototype
    
    some architectures run into a -Wmissing-prototypes warning
    for trap_init()
    
    arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for 'trap_init' [-Wmissing-prototypes]
    
    Include the right header to avoid this consistently, removing
    the extra declarations on m68k and x86 that were added as local
    workarounds already.
    
    Signed-off-by: Arnd Bergmann <arnd@...db.de>


I made the same mistake with the "arch: add do_page_fault prototypes"
patch that was missing an explanation.

      Arnd