linux-kernel - Re: [PATCH v2] mm/page_alloc: Dedupe some memcg uncharging logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALvZod4Uj9rR3OL7CYfq5t8gsRLAa7b2wa3m26nyDhfvQaWQ+g@mail.gmail.com>
Date:   Wed, 8 Nov 2023 15:51:51 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Brendan Jackman <jackmanb@...gle.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Muchun Song <muchun.song@...ux.dev>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] mm/page_alloc: Dedupe some memcg uncharging logic

On Wed, Nov 8, 2023 at 8:49 AM Brendan Jackman <jackmanb@...gle.com> wrote:
>
> The duplication makes it seem like some work is required before
> uncharging in the !PageHWPoison case. But it isn't, so we can simplify
> the code a little.
>
> Note the PageMemcgKmem check is redundant, but I've left it in as it
> avoids an unnecessary function call.
>
> Signed-off-by: Brendan Jackman <jackmanb@...gle.com>

Thanks for the patch. Actually the PageMemcgKmem/folio_memcg_kmem
check should be in memcg_kmem_uncharge_page() and not in
__memcg_kmem_uncharge_page(). Anyways, that is orthogonal to this
patch.

Acked-by: Shakeel Butt <shakeelb@...gle.com>