linux-kernel - Re: [PATCH V2] blk-mq: fix warning in blk_mq_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZUs4JIu0NBz2RWys@infradead.org>
Date:   Tue, 7 Nov 2023 23:26:28 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Edward Adam Davis <eadavis@...com>
Cc:     bvanassche@....org, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+fcc47ba2476570cbbeb0@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH V2] blk-mq: fix warning in blk_mq_start_request

On Wed, Nov 08, 2023 at 02:59:40PM +0800, Edward Adam Davis wrote:
> Before call queue_rq(), initialize rq->state to MQ_RQ_IDLE.

Request should never be able to be allocated if they aren't in
MQ_RQ_IDLE.  So papering over it here is not the right fix, we need
to figure out got it ends up being marked free in the bitmap while
not idle.