linux-kernel - Re: [PATCH] selftests: kvm/s390x: use vm_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231108112005.54e86585@p-imbrenda>
Date:   Wed, 8 Nov 2023 11:20:05 +0100
From:   Claudio Imbrenda <imbrenda@...ux.ibm.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] selftests: kvm/s390x: use vm_create_barebones()

On Wed,  8 Nov 2023 04:40:55 -0500
Paolo Bonzini <pbonzini@...hat.com> wrote:

> This function does the same but makes it clearer why one would use
> the "____"-prefixed version of vm_create().
> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

> ---
>  tools/testing/selftests/kvm/s390x/cmma_test.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/s390x/cmma_test.c b/tools/testing/selftests/kvm/s390x/cmma_test.c
> index c8e0a6495a63..626a2b8a2037 100644
> --- a/tools/testing/selftests/kvm/s390x/cmma_test.c
> +++ b/tools/testing/selftests/kvm/s390x/cmma_test.c
> @@ -94,11 +94,6 @@ static void guest_dirty_test_data(void)
>  	);
>  }
>  
> -static struct kvm_vm *create_vm(void)
> -{
> -	return ____vm_create(VM_MODE_DEFAULT);
> -}
> -
>  static void create_main_memslot(struct kvm_vm *vm)
>  {
>  	int i;
> @@ -157,7 +152,7 @@ static struct kvm_vm *create_vm_two_memslots(void)
>  {
>  	struct kvm_vm *vm;
>  
> -	vm = create_vm();
> +	vm = vm_create_barebones();
>  
>  	create_memslots(vm);
>  
> @@ -276,7 +271,7 @@ static void assert_exit_was_hypercall(struct kvm_vcpu *vcpu)
>  
>  static void test_migration_mode(void)
>  {
> -	struct kvm_vm *vm = create_vm();
> +	struct kvm_vm *vm = vm_create_barebones();
>  	struct kvm_vcpu *vcpu;
>  	u64 orig_psw;
>  	int rc;
> @@ -670,7 +665,7 @@ struct testdef {
>   */
>  static int machine_has_cmma(void)
>  {
> -	struct kvm_vm *vm = create_vm();
> +	struct kvm_vm *vm = vm_create_barebones();
>  	int r;
>  
>  	r = !__kvm_has_device_attr(vm->fd, KVM_S390_VM_MEM_CTRL, KVM_S390_VM_MEM_ENABLE_CMMA);