linux-kernel - Re: [PATCH RFC 02/20] rust_binder: add binderfs support to Rust binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231108103103.524922-1-aliceryhl@google.com>
Date:   Wed,  8 Nov 2023 10:31:03 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     me@...enk.de
Cc:     a.hindborg@...sung.com, alex.gaynor@...il.com,
        aliceryhl@...gle.com, arve@...roid.com, benno.lossin@...ton.me,
        bjorn3_gh@...tonmail.com, boqun.feng@...il.com, brauner@...nel.org,
        cmllamas@...gle.com, gary@...yguo.net, gregkh@...uxfoundation.org,
        jeffv@...gle.com, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, maco@...roid.com,
        mattgilbride@...gle.com, mmaurer@...gle.com, ojeda@...nel.org,
        rust-for-linux@...r.kernel.org, surenb@...gle.com,
        tkjos@...roid.com, wedsonaf@...il.com
Subject: Re: [PATCH RFC 02/20] rust_binder: add binderfs support to Rust binder

Finn Behrens <finn@...enk.de> writes:
> On 1 Nov 2023, at 19:01, Alice Ryhl wrote:
>> +macro_rules! decl_wrapper {
>> +    ($newname:ident, $wrapped:ty) => {
>> +        #[derive(Copy, Clone, Default)]
>> +        #[repr(transparent)]
>> +        pub(crate) struct $newname($wrapped);
>> +        // SAFETY: This macro is only used with types where this is ok.
> 
> Would it make sense so also annotade this safety requirement on the
> macro itself?
> 
> It is only file private, but could help not overlook it, when using for
> something new in the same file.

Sure, I can move the comment.

Alice