linux-kernel - Re: [PATCH v2 3/4] locking/atomic: openrisc: arch_cmpxchg[64]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231108100322.06cc58b4fd142ccbb8d3751e@kernel.org>
Date:   Wed, 8 Nov 2023 10:03:22 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     "wuqiang.matt" <wuqiang.matt@...edance.com>
Cc:     vgupta@...nel.org, bcain@...cinc.com, jonas@...thpole.se,
        stefan.kristiansson@...nalahti.fi, shorne@...il.com,
        geert@...ux-m68k.org, andi.shyti@...ux.intel.com, mingo@...nel.org,
        palmer@...osinc.com, andrzej.hajda@...el.com, arnd@...db.de,
        peterz@...radead.orgm, linux-snps-arc@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-openrisc@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        mattwu@....com, linux@...ck-us.ne
Subject: Re: [PATCH v2 3/4] locking/atomic: openrisc: arch_cmpxchg[64]_local
 undefined

On Sat,  4 Nov 2023 17:16:14 +0800
"wuqiang.matt" <wuqiang.matt@...edance.com> wrote:

> For architectures that support native cmpxchg, we'd like to
> implement arch_cmpxchg[64]_local with the native variants of
> supported data size. If not, the generci_cmpxchg[64]_local
> will be used.


Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

> 
> Signed-off-by: wuqiang.matt <wuqiang.matt@...edance.com>
> ---
>  arch/openrisc/include/asm/cmpxchg.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/openrisc/include/asm/cmpxchg.h b/arch/openrisc/include/asm/cmpxchg.h
> index 8ee151c072e4..f1ffe8b6f5ef 100644
> --- a/arch/openrisc/include/asm/cmpxchg.h
> +++ b/arch/openrisc/include/asm/cmpxchg.h
> @@ -139,6 +139,12 @@ static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old,
>  					       (unsigned long)(n),	\
>  					       sizeof(*(ptr)));		\
>  	})
> +#define arch_cmpxchg_local arch_cmpxchg
> +
> +/* always make arch_cmpxchg64_local available for openrisc */
> +#include <asm-generic/cmpxchg-local.h>
> +
> +#define arch_cmpxchg64_local(ptr, o, n) __generic_cmpxchg64_local((ptr), (o), (n))
>  
>  /*
>   * This function doesn't exist, so you'll get a linker error if
> -- 
> 2.40.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>