linux-kernel - [PATCH] greybus: beagleplay: select CONFIG_CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231108153429.1072732-1-arnd@kernel.org>
Date:   Wed,  8 Nov 2023 16:34:24 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Ayush Singh <ayushdevel1325@...il.com>,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT

From: Arnd Bergmann <arnd@...db.de>

Without the CRC_CCITT code, the new greybus driver fails to link:

aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'

Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/greybus/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
index 033d31dbf3b8..ab81ceceb337 100644
--- a/drivers/greybus/Kconfig
+++ b/drivers/greybus/Kconfig
@@ -20,6 +20,7 @@ if GREYBUS
 config GREYBUS_BEAGLEPLAY
 	tristate "Greybus BeaglePlay driver"
 	depends on SERIAL_DEV_BUS
+	select CRC_CCITT
 	help
 	  Select this option if you have a BeaglePlay where CC1352
 	  co-processor acts as Greybus SVC.
-- 
2.39.2