linux-kernel - Re: [PATCH] greybus: beagleplay: select CONFIG_CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2023 17:25:18 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Arnd Bergmann <arnd@...nel.org>, Johan Hovold <johan@...nel.org>,
        Alex Elder <elder@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Ayush Singh <ayushdevel1325@...il.com>,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT

On Wed, Nov 08, 2023 at 08:12:57AM -0800, Randy Dunlap wrote:
> 
> 
> On 11/8/23 07:34, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > Without the CRC_CCITT code, the new greybus driver fails to link:
> > 
> > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> > gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
> > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
> > gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/greybus/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> > index 033d31dbf3b8..ab81ceceb337 100644
> > --- a/drivers/greybus/Kconfig
> > +++ b/drivers/greybus/Kconfig
> > @@ -20,6 +20,7 @@ if GREYBUS
> >  config GREYBUS_BEAGLEPLAY
> >  	tristate "Greybus BeaglePlay driver"
> >  	depends on SERIAL_DEV_BUS
> > +	select CRC_CCITT
> >  	help
> >  	  Select this option if you have a BeaglePlay where CC1352
> >  	  co-processor acts as Greybus SVC.
> 
> Yes, same as my patch:
> https://lore.kernel.org/lkml/20231031040909.21201-1-rdunlap@infradead.org/
> 
> I expect that Greg just hasn't gotten around to applying new patches/fixes yet.

Nope, waiting until -rc1 is out, sorry.

greg k-h