linux-kernel - Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2023 10:40:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     Rafał Miłecki <rafal@...ecki.pl>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Julius Werner <jwerner@...omium.org>,
        Evan Benn <evanbenn@...omium.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Maxime Ripard <mripard@...nel.org>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Justin Chen <justinpopo6@...il.com>,
        Baruch Siach <baruch@...s.co.il>,
        Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
        Marc Zyngier <maz@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jamie Iles <jamie@...ieiles.com>,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match
 coding convention

On Mon, Nov 06, 2023 at 09:10:44AM +0100, Rafał Miłecki wrote:
> On 2023-11-05 19:41, Krzysztof Kozlowski wrote:
> > The Devicetree bindings coding convention, as used in most of the files
> > and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> > expects:
> > 1. "allOf:" block just before "properties:" (or after "required:" for
> >    more complex cases),
> > 2. additionalProperties/unevaluatedProperties at the end of the file,
> >    just before the examples section.
> > 
> > Re-order few schemas to match the convention to avoid repeating review
> > comments for new patches using existing code as template.  No functional
> > changes.
> 
> It's surely going to help a bit but for a long time solution maybe you
> could consider adding proper check to Rob's bot and/or checkpatch.pl.

I have such a check I wrote long ago. tools/yaml-format in dtschema. It 
just does a ruamel read and write back out so you get exactly how ruamel 
is configured or defaults to for things not configurable. Primarily, the 
non-configurable part is multi-line text without a '|'. So lots of 
'description' paragraphs are reformatted. It ends up being too strict 
IMO.

The key order is checked, but not fixed. Probably could add reordering.

Adding this by default (and to the bot) means fixing *every* file in 
tree first. That's not something I care to do and enforce.

Rob