linux-kernel - Re: [PATCH v1] spi: Fix null dereference on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169946485678.3169019.15980438367313044998.b4-ty@kernel.org>
Date:   Wed, 08 Nov 2023 17:34:16 +0000
From:   Mark Brown <broonie@...nel.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Mark Hasemeyer <markhas@...omium.org>
Cc:     linux-spi@...r.kernel.org
Subject: Re: [PATCH v1] spi: Fix null dereference on suspend

On Tue, 07 Nov 2023 14:47:43 -0700, Mark Hasemeyer wrote:
> A race condition exists where a synchronous (noqueue) transfer can be
> active during a system suspend. This can cause a null pointer
> dereference exception to occur when the system resumes.
> 
> Example order of events leading to the exception:
> 1. spi_sync() calls __spi_transfer_message_noqueue() which sets
>    ctlr->cur_msg
> 2. Spi transfer begins via spi_transfer_one_message()
> 3. System is suspended interrupting the transfer context
> 4. System is resumed
> 6. spi_controller_resume() calls spi_start_queue() which resets cur_msg
>    to NULL
> 7. Spi transfer context resumes and spi_finalize_current_message() is
>    called which dereferences cur_msg (which is now NULL)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: Fix null dereference on suspend
      commit: 4f646616d11c3ec3f5a5cb2cd683cfc0fa9a5018

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark