linux-kernel - Re: [PATCH] debugfs: only clean up d_fsdata for d_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33254d48b38755e924cdae30bffdf5bc9b6bccd1.camel@sipsolutions.net>
Date:   Thu, 09 Nov 2023 19:40:16 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     linux-kernel@...r.kernel.org
Cc:     linux-fsdevel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Nicolai Stange <nicstange@...il.com>
Subject: Re: [PATCH] debugfs: only clean up d_fsdata for d_is_reg()

On Thu, 2023-11-09 at 16:06 +0100, Johannes Berg wrote:
> 
> @@ -734,6 +725,11 @@ static void __debugfs_file_removed(struct dentry *dentry)
>  		return;
>  	if (!refcount_dec_and_test(&fsd->active_users))
>  		wait_for_completion(&fsd->active_users_drained);
> +
> +	/* this no longer matters */
> +	dentry->d_fsdata = NULL;
> 

That's not true, and therefore this patch is wrong -
full_proxy_release() still happens later.

Not sure why I didn't see that originally, even in tests.

I'll try again :)

johannes