linux-kernel - Re: [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2023 15:06:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mehdi Djait <mehdi.djait@...tlin.com>, mchehab@...nel.org,
        heiko@...ech.de, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        maxime.chevallier@...tlin.com, paul.kocialkowski@...tlin.com,
        Mehdi Djait <mehdi.djait@...tlin.com>
Subject: Re: [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell
 TW9900 decoder

Hi Mehdi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linuxtv-media-stage/master linus/master v6.6 next-20231109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mehdi-Djait/dt-bindings-vendor-prefixes-Add-techwell-vendor-prefix/20231109-042139
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/93354996c95926970684498f08061b60a52bb84c.1699449537.git.mehdi.djait%40bootlin.com
patch subject: [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20231109/202311091458.0Mnol4EW-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231109/202311091458.0Mnol4EW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311091458.0Mnol4EW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/tw9900.c:359:12: warning: 'tw9900_runtime_suspend' defined but not used [-Wunused-function]
     359 | static int tw9900_runtime_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/i2c/tw9900.c:350:12: warning: 'tw9900_runtime_resume' defined but not used [-Wunused-function]
     350 | static int tw9900_runtime_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~


vim +/tw9900_runtime_suspend +359 drivers/media/i2c/tw9900.c

   349	
 > 350	static int tw9900_runtime_resume(struct device *dev)
   351	{
   352		struct i2c_client *client = to_i2c_client(dev);
   353		struct v4l2_subdev *sd = i2c_get_clientdata(client);
   354		struct tw9900 *tw9900 = to_tw9900(sd);
   355	
   356		return tw9900_power_on(tw9900);
   357	}
   358	
 > 359	static int tw9900_runtime_suspend(struct device *dev)
   360	{
   361		struct i2c_client *client = to_i2c_client(dev);
   362		struct v4l2_subdev *sd = i2c_get_clientdata(client);
   363		struct tw9900 *tw9900 = to_tw9900(sd);
   364	
   365		tw9900_power_off(tw9900);
   366	
   367		return 0;
   368	}
   369	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki