linux-kernel - Re: [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231109-send-pushchair-45b37551102a@wendy>
Date:   Thu, 9 Nov 2023 07:29:13 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     zhangqing <zhangqing@...k-chips.com>
CC:     Conor Dooley <conor@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <kever.yang@...k-chips.com>, <heiko@...ech.de>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-clk@...r.kernel.org>, <linux-rockchip@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <huangtao@...k-chips.com>,
        <andy.yan@...k-chips.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF
 clk id

On Thu, Nov 09, 2023 at 02:27:38PM +0800, zhangqing wrote:
> Hi:
> 
> 在 2023/11/8 20:01, Conor Dooley 写道:
> > On Wed, Nov 08, 2023 at 02:18:21PM +0800, Elaine Zhang wrote:
> > > export PCLK_VO1GRF for DT.
> > > 
> > > Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> > > ---
> > >   include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > index 5790b1391201..50ba72980190 100644
> > > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > @@ -733,8 +733,9 @@
> > >   #define ACLK_AV1_PRE			718
> > >   #define PCLK_AV1_PRE			719
> > >   #define HCLK_SDIO_PRE			720
> > > +#define PCLK_VO1GRF			721
> > > -#define CLK_NR_CLKS			(HCLK_SDIO_PRE + 1)
> > > +#define CLK_NR_CLKS			(PCLK_VO1GRF + 1)
> > This definition is part of the ABI, if it is safe to change it, then it
> > is safe to delete it.
> The new ID is to solve the niu clock dependency problem(Used in PATCH V5
> 4/4).This new ID will also be used in DTS in the future.
> 
> CLK_NR_CLKS represents the number of clocks used by the
> drivers/clk/rockchip/clk-rkxxx.c. It is safe to modify it, but cannot delete
> it.

Then delete it from the header and move it to clk-rkxxx.c

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)