linux-kernel - Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <143f5411-9fc0-4e88-9e35-6f3679b6f930@redhat.com>
Date:   Thu, 9 Nov 2023 09:25:43 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Anish Moorthy <amoorthy@...gle.com>
Cc:     ackerleytng@...gle.com, akpm@...ux-foundation.org,
        anup@...infault.org, aou@...s.berkeley.edu, brauner@...nel.org,
        chao.p.peng@...ux.intel.com, chenhuacai@...nel.org,
        david@...hat.com, dmatlack@...gle.com, isaku.yamahata@...il.com,
        isaku.yamahata@...el.com, jarkko@...nel.org,
        kirill.shutemov@...ux.intel.com, kvm-riscv@...ts.infradead.org,
        kvm@...r.kernel.org, kvmarm@...ts.linux.dev,
        liam.merwick@...cle.com, linux-arm-kernel@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-mm@...ck.org,
        linux-riscv@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
        mail@...iej.szmigiero.name, maz@...nel.org, mic@...ikod.net,
        michael.roth@....com, mpe@...erman.id.au, oliver.upton@...ux.dev,
        palmer@...belt.com, paul.walmsley@...ive.com, qperret@...gle.com,
        seanjc@...gle.com, tabba@...gle.com, vannapurve@...gle.com,
        vbabka@...e.cz, viro@...iv.linux.org.uk, wei.w.wang@...el.com,
        willy@...radead.org, xiaoyao.li@...el.com, yilun.xu@...el.com,
        yu.c.zhang@...ux.intel.com
Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests
 to specify the VM type

On 11/9/23 00:37, Anish Moorthy wrote:
> On Wed, Nov 8, 2023 at 9:00 AM Anish Moorthy <amoorthy@...gle.com> wrote:
>>
>> This commit breaks the arm64 selftests build btw: looks like a simple oversight?
> 
> Yup, fix is a one-liner. Posted below.
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> index eb4217b7c768..08a5ca5bed56 100644
> --- a/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> +++ b/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> @@ -705,7 +705,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
>   
>   	print_test_banner(mode, p);
>   
> -	vm = ____vm_create(mode);
> +	vm = ____vm_create(VM_SHAPE(mode));

Yes, this is similar to the s390 patch I sent yesterday 
(https://patchew.org/linux/20231108094055.221234-1-pbonzini@redhat.com/).

Paolo