linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: light: add ltr390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <844937f1-b3f7-4156-b60a-e9e17d8aed6e@gmail.com>
Date:   Thu, 9 Nov 2023 16:05:33 +0530
From:   Anshul Dalal <anshulusr@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: add ltr390

Hello Krzysztof,

On 11/9/23 15:57, Krzysztof Kozlowski wrote:
> On 09/11/2023 10:04, Anshul Dalal wrote:
>> Add binding for Lite-On LTR390 which is an Ambient/UV light sensor that
>> communicates over i2c with an address of 0x53.
>>
>> Datasheet:
>>   https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
>>
>> Signed-off-by: Anshul Dalal <anshulusr@...il.com>
> 
> 
>> +  interrupts:
>> +    maxItems: 1
>> +    description: |
>> +      Level interrupt pin with open drain output.
>> +      The sensor pulls this pin low when the measured reading is greater than
>> +      some configured threshold.
>> +
>> +  vdd-supply: true
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        light-sensor@53 {
>> +            compatible = "liteon,ltr390";
>> +            reg = <0x53>;
> 
> Please extend the example to be complete - interrupts and vdd-supply.

Could the following be used as a suitable example.

#include <dt-bindings/interrupt-controller/irq.h>

i2c {
    #address-cells = <1>;
    #size-cells = <0>;

    light-sensor@53 {
        compatible = "liteon,ltr390";
        reg = <0x53>;
        interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
        vdd-supply = <&vdd_regulator>;
    };
};

Thanks for the review.

Best regards,
Anshul