linux-kernel - Re: [PATCH] x86/shstk: Change SSP after user accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUzjLy0IzqypDHYV@finisterre.sirena.org.uk>
Date:   Thu, 9 Nov 2023 13:49:00 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Rick Edgecombe <rick.p.edgecombe@...el.com>
Cc:     x86@...nel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, luto@...nel.org,
        peterz@...radead.org, linux-kernel@...r.kernel.org,
        debug@...osinc.com, pengfei.xu@...el.com
Subject: Re: [PATCH] x86/shstk: Change SSP after user accesses

On Tue, Nov 07, 2023 at 10:22:51AM -0800, Rick Edgecombe wrote:

> Fix this by adjusting the SSP register only after any userspace accesses,
> such that there can be no failures after the SSP is adjusted. Do this by
> moving the shadow stack sigframe push logic to happen after all other
> userspace accesses.

Thanks for the heads up on this.  From inspection it looks like the
arm64 patches currently order things similarly to your new x86 code.

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)