linux-kernel - Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231109161656.GH3752@thinkpad>
Date:   Thu, 9 Nov 2023 21:46:56 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Bart Van Assche <bvanassche@....org>,
        Ziqi Chen <quic_ziqichen@...cinc.com>,
        quic_asutoshd@...cinc.com, quic_cang@...cinc.com,
        beanhuo@...ron.com, avri.altman@....com, junwoo80.lee@...sung.com,
        martin.petersen@...cle.com, quic_nguyenb@...cinc.com,
        quic_nitirawa@...cinc.com, quic_rampraka@...cinc.com,
        linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Mark Brown <broonie@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ

On Thu, Nov 09, 2023 at 07:55:14AM -0600, Rob Herring wrote:
> On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@....org> wrote:
> >
> > On 11/6/23 06:48, Rob Herring wrote:
> > > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> > >> The Message Signaled Interrupts (MSI) has been introduced
> > >> to UFS driver since the MCQ be enabled.
> > >
> > > Not really relevant when a driver supported MSI, but the when the h/w
> > > did. Has UFS always supported MSI? It was added in some version of the
> > > spec?
> >
> > MSI support has been introduced in UFSHCI version 4.0 and I think that
> > the controller vendor can decide whether or not to implement MSI. Does
> > this mean that the patch needs to be improved?
> 
> Yes, this information is what should be in the commit msg rather than
> driver details.
> 

Yes, agreed. Ziqi, please update the commit message to incorporate the hw
details about when MCQ/MSI got introduced. Devicetree binding should describe
the hw, not the driver.

- Mani

> Rob

-- 
மணிவண்ணன் சதாசிவம்