linux-kernel - Re: [PATCH 02/41] rxrpc: Fix two connection reaping bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e66a2cd-ea6f-4427-a22a-f1d0c5a33c1c@auristor.com>
Date:   Thu, 9 Nov 2023 12:27:52 -0500
From:   Jeffrey E Altman <jaltman@...istor.com>
To:     David Howells <dhowells@...hat.com>,
        Marc Dionne <marc.dionne@...istor.com>
Cc:     linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 02/41] rxrpc: Fix two connection reaping bugs

On 11/9/2023 10:39 AM, David Howells wrote:
> Fix two connection reaping bugs:
>
>   (1) rxrpc_connection_expiry is in units of seconds, so
>       rxrpc_disconnect_call() needs to multiply it by HZ when adding it to
>       jiffies.
>
>   (2) rxrpc_client_conn_reap_timeout() should set RXRPC_CLIENT_REAP_TIMER if
>       local->kill_all_client_conns is clear, not if it is set (in which case
>       we don't need the timer).  Without this, old client connections don't
>       get cleaned up until the local endpoint is cleaned up.
>
> Fixes: 5040011d073d ("rxrpc: Make the local endpoint hold a ref on a connected call")
> Fixes: 0d6bf319bc5a ("rxrpc: Move the client conn cache management to the I/O thread")
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Marc Dionne <marc.dionne@...istor.com>
> cc: "David S. Miller" <davem@...emloft.net>
> cc: Eric Dumazet <edumazet@...gle.com>
> cc: Jakub Kicinski <kuba@...nel.org>
> cc: Paolo Abeni <pabeni@...hat.com>
> cc: netdev@...r.kernel.org
> cc: linux-afs@...ts.infradead.org
> ---
Reviewed-by: Jeffrey Altman <jaltman@...istor.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4039 bytes)