linux-kernel - Re: [PATCH v10 1/3] media: dt-bindings: media: add bindings for Rockchip CIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2023 18:53:12 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Conor Dooley <conor@...nel.org>
Cc:     Mehdi Djait <mehdi.djait@...tlin.com>, mchehab@...nel.org,
        heiko@...ech.de, hverkuil-cisco@...all.nl,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        maxime.chevallier@...tlin.com, michael.riesch@...fvision.net
Subject: Re: [PATCH v10 1/3] media: dt-bindings: media: add bindings for
 Rockchip CIF

On 09/11/2023 18:45, Paul Kocialkowski wrote:
> Hi,
> 
> On Thu 09 Nov 23, 17:24, Conor Dooley wrote:
>> On Wed, Nov 08, 2023 at 05:38:56PM +0100, Mehdi Djait wrote:
>>> Add a documentation for the Rockchip Camera Interface binding.
>>>
>>> the name of the file rk3066 is the first Rockchip SoC generation that uses cif
>>> instead of the px30 which is just one of the many iterations of the unit.
>>
>> I think this is becoming ridiculous. You've now removed the compatible
>> for the rk3066 but kept it in the filename. I don't understand the
>> hangup about naming the file after the px30-vip, but naming it after
>> something that is not documented here at all makes no sense to me.
>> Either document the rk3066 properly, or remove all mention of it IMO.
> 
> I think the opposite is ridiculous. We have spent some time investigating the
> history of this unit, to find out that RK3066 is the first occurence where
> it exists. Since we want the binding to cover all generations of the same unit
> and give it a name that reflects this, rk3066 is the natural choice that comes
> to mind. As far as I understand, this is the normal thing to do to name
> bindings: name after the earliest known occurence of the unit.
> 
> What is the rationale behind naming the file after a generation of the unit
> that happens to be the one introducing the binding? This is neither the first
> nor the last one to include this unit. The binding will be updated later to
> cover other generations. Do we want to rename the file each time an a generation
> earlier than px30 is introduced? That sounds quite ridiculous too.
> 
> We've done the research work to give it the most relevant name here.
> I'd expect some strong arguments not to use it. Can you ellaborate?

If you do not have rk3066 documented here, it might be added to entirely
different file (for whatever reasons, including that binding would be
quite different than px30). Thus you would have rk3066 in
rockchip,rk3066-cif-added-later.yaml and px30 in rockchip,rk3066-cif.yaml

Just use the filename matching the compatible. That's what we always
ask. In every review.

Best regards,
Krzysztof