linux-kernel - RE: [PATCH v2 2/4] phy: realtek: usb: add new driver for the Realtek RTD SoC USB 2.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db2ccd248e5e4c3d8f818a3b3e2ef909@realtek.com>
Date:   Fri, 10 Nov 2023 02:58:24 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Vinod Koul <vkoul@...nel.org>, Johan Hovold <johan@...nel.org>,
        "Kishon Vijay Abraham I" <kishon@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh@...nel.org>,
        Jinjie Ruan <ruanjinjie@...wei.com>,
        Alan Stern <stern@...land.harvard.edu>,
        "Yang Yingliang" <yangyingliang@...wei.com>,
        Roy Luo <royluo@...gle.com>,
        Ricardo Cañuelo 
        <ricardo.canuelo@...labora.com>,
        "Heikki Krogerus" <heikki.krogerus@...ux.intel.com>,
        Ray Chi <raychi@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v2 2/4] phy: realtek: usb: add new driver for the Realtek RTD SoC USB 2.0 PHY

Hi Krzysztof,

> ...
> > +
> > +static const struct of_device_id usbphy_rtk_dt_match[] = {
> > +     { .compatible = "realtek,rtd1295-usb2phy", .data =
> &rtd1295_phy_cfg },
> > +     { .compatible = "realtek,rtd1312c-usb2phy", .data =
> &rtd1312c_phy_cfg },
> > +     { .compatible = "realtek,rtd1315e-usb2phy", .data =
> &rtd1315e_phy_cfg },
> > +     { .compatible = "realtek,rtd1319-usb2phy", .data =
> &rtd1319_phy_cfg },
> > +     { .compatible = "realtek,rtd1319d-usb2phy", .data =
> &rtd1319d_phy_cfg },
> > +     { .compatible = "realtek,rtd1395-usb2phy", .data =
> &rtd1395_phy_cfg },
> > +     { .compatible = "realtek,rtd1395-usb2phy-2port", .data =
> &rtd1395_phy_cfg_2port },
> > +     { .compatible = "realtek,rtd1619-usb2phy", .data =
> &rtd1619_phy_cfg },
> > +     { .compatible = "realtek,rtd1619b-usb2phy", .data =
> > +&rtd1619b_phy_cfg },
> 
> Why is this sent separately from the bindings?

The binding is ready on 612ad27a30455 (dt-bindings: phy: realtek: Add Realtek DHC RTD SoC USB 2.0 PHY)

This patch is resubmit base on 7a784bcdd7e5 (Revert "phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY")
to avoid using legacy USB PHY framework.

> > +     {},
> > +};
> > +MODULE_DEVICE_TABLE(of, usbphy_rtk_dt_match);
> > +
> > +static struct platform_driver rtk_usb2phy_driver = {
> > +     .probe          = rtk_usb2phy_probe,
> > +     .remove_new     = rtk_usb2phy_remove,
> > +     .driver         = {
> > +             .name   = "rtk-usb2phy",
> > +             .of_match_table = usbphy_rtk_dt_match,
> > +     },
> > +};
> > +
> > +module_platform_driver(rtk_usb2phy_driver);
> > +
> > +MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("platform: rtk-usb2phy");
> 
> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
> means your device ID table is wrong (e.g. misses either entries or
> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for
> incomplete ID table.
> 
I will remove this.

Thanks,
Stanley