linux-kernel - Re: [PATCH net v2] ncsi: Revert NCSI link loss/gain commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Nov 2023 17:31:51 +0000
From:   Simon Horman <horms@...nel.org>
To:     Johnathan Mantey <johnathanx.mantey@...el.com>
Cc:     netdev@...r.kernel.org, sam@...dozajonas.com, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] ncsi: Revert NCSI link loss/gain commit

On Thu, Nov 09, 2023 at 12:51:37PM -0800, Johnathan Mantey wrote:
> The NCSI commit
> ncsi: Propagate carrier gain/loss events to the NCSI controller
> introduced unwanted behavior.
> 
> The intent for the commit was to be able to detect carrier loss/gain
> for just the NIC connected to the BMC. The unwanted effect is a
> carrier loss for auxiliary paths also causes the BMC to lose
> carrier. The BMC never regains carrier despite the secondary NIC
> regaining a link.
> 
> This change, when merged, needs to be backported to stable kernels.
> 5.4-stable, 5.10-stable, 5.15-stable, 6.1-stable, 6.5-stable
> 
> Fixes: 3780bb29311e ncsi: Propagate carrier gain/loss events to the
> CC: stable@...r.kernel.org
> Signed-off-by: Johnathan Mantey <johnathanx.mantey@...el.com>

Hi Johnathan,

thanks for your patch.
Some minor feedback from my side.

1. The correct format for the tag above is:

   Fixes: 3780bb29311e ("ncsi: Propagate carrier gain/loss events to the NCSI controller")

2. I think it is usual to format the subject and commit messages for
   revert commits a bit like this:

   Subject: [PATCH net vX] Revert "ncsi: Propagate carrier gain/loss events to the NCSI controller"

   This reverts commit 3780bb29311eccb7a1c9641032a112eed237f7e3.

   The cited commit introduced unwanted behavior.

   The intent for the commit was to be able to detect carrier loss/gain
   for just the NIC connected to the BMC. The unwanted effect is a
   carrier loss for auxiliary paths also causes the BMC to lose
   carrier. The BMC never regains carrier despite the secondary NIC
   regaining a link.

   ...