linux-kernel - Re: Re: [PATCH v6] platform/x86: inspur-platform-profile: Add platform profile support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 10 Nov 2023 15:22:10 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     艾超 <aichao@...inos.cn>
cc:     Hans de Goede <hdegoede@...hat.com>,
        markgross <markgross@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86 <platform-driver-x86@...r.kernel.org>
Subject: Re: Re: [PATCH v6] platform/x86: inspur-platform-profile: Add platform
 profile support

On Fri, 10 Nov 2023, 艾超 wrote:

>     I'm sorry, receive a mail from  kernel test robot<lkp@...el.com> , that:
>
> > kernel test robot noticed the following build warnings:
> 
> > [auto build test WARNING on linus/master]
> > [also build test WARNING on v6.6]
> > [cannot apply to next-20231102]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.

I'm aware of those, which is why I fixed those /** -> /* while I applied 
your patch so that problem has already been taken care of!

> > If you fix the issue in a separate patch/commit (i.e. not just a new
> version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot
> > | Closes:
> https://lore.kernel.org/oe-kbuild-all/202311021547.KTmJVY2O-lkp@intel.com/
> 
>  
> 
> > All warnings (new ones prefixed by >>):
> 
> > >  drivers/platform/x86/inspur_platform_profile.c:27: warning: cannot
> understand function prototype: 'enum  inspur_tmp_profile '
> > drivers/platform/x86/inspur_platform_profile.c:74: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> > * Set Power Mode to EC RAM. If Power Mode value greater than 0x3,
> > drivers/platform/x86/inspur_platform_profile.c:123: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> >  * Get Power Mode from EC RAM, If Power Mode value greater than 0x3,
> 
> >  vim +27 drivers/platform/x86/inspur_platform_profile.c
> 
>  
> 
>  And I forget to add "Reported-by: kernel test robot" in this patch.

I know the message from lkp sounds like that (and it is slightly 
confusing) but it is to be added only when you're fixing code that has 
already made into a maintainer tree.

If one is submitting entirely new code and lkp finds and issue, one is not 
supposed to add that reported by even if the message tells you to do so. I 
hope this clears any confusion you might have about when it's needed.

-- 
 i.

> On Thu, 9 Nov 2023, Ai Chao wrote:
> 
> > Add support for Inspur platforms to used the platform profile feature.
> >
> > This will allow users to determine and control the platform modes
> > between low-power, balanced and performance modes.
> >
> > Signed-off-by: Ai Chao
> > ---
> >
> > v6: Remove comment for inspur_tmp_profile
> > v5: Rename inspur-wmi to inspur_platform_profile
> > v4: Add select ACPI_PLATFORM_PROFILE
> > v3: Remove input device, using the platform profile interface
> > v2: Remove Event GUID, remove inspur_wmi_notify and inspur_wmi_notify.
> 
> Hi,
> 
> I already took your v5 and it has since made also into Linus' tree.
> 
> If you want to make further changes to the driver, place them as
> incremental changes on top of what's already included, thank you.
> 
> --
> i.
> 
> 
>