lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231110173632.2511-1-bragathemanick0908@gmail.com> Date: Fri, 10 Nov 2023 23:06:32 +0530 From: Bragatheswaran Manickavel <bragathemanick0908@...il.com> To: ralf@...ux-mips.org, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Cc: Bragatheswaran Manickavel <bragathemanick0908@...il.com>, linux-hams@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, syzbot+0145ea560de205bc09f0@...kaller.appspotmail.com Subject: [PATCH] net: memory leak in nr_rx_frame The condition (make = nr_make_new(sk)) == NULL suggests that nr_make_new allocates memory and returns a pointer. If this allocation fails (returns NULL), it indicates a potential memory leak. Added sock_put() for make which can potentially solve this issue Reported-by: syzbot+0145ea560de205bc09f0@...kaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0145ea560de205bc09f0 Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@...il.com> --- net/netrom/af_netrom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 0eed00184adf..7d7cda4ae300 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -970,6 +970,8 @@ int nr_rx_frame(struct sk_buff *skb, struct net_device *dev) nr_transmit_refusal(skb, 0); if (sk) sock_put(sk); + if (make) + sock_put(make); return 0; } -- 2.34.1
Powered by blists - more mailing lists