linux-kernel - Re: [PATCH] Revert "i2c: pxa: move to generic GPIO recovery"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZU37aJfDpcixU2OZ@shell.armlinux.org.uk>
Date:   Fri, 10 Nov 2023 09:44:08 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Robert Marko <robert.marko@...tura.hr>
Cc:     andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linus.walleij@...aro.org,
        wsa@...nel.org, codrin.ciubotariu@...rochip.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] Revert "i2c: pxa: move to generic GPIO recovery"

On Fri, Nov 10, 2023 at 10:30:11AM +0100, Robert Marko wrote:
> This reverts commit 0b01392c18b9993a584f36ace1d61118772ad0ca.
> 
> Conversion of PXA to generic I2C recovery, makes the I2C bus completely
> lock up if recovery pinctrl is present in the DT and I2C recovery is
> enabled.
> 
> So, until the generic I2C recovery can also work with PXA lets revert
> to have working I2C and I2C recovery again.
> 
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> Cc: stable@...r.kernel.org # 5.11+

My feels were that this should not have been converted to the generic
recovery as pointed out at the time, so thanks for confirming that it
broke as a result of that conversion, it did indeed break.

Acked-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!