linux-kernel - Re: [PATCH] drm/tests: Add KUnit tests for drm_mode_create_dvi_i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2nkuewkbcgbqjfklpqf74lgiwnidcyr3bgr42neq3xnrvawcp@g4iketyic4q4>
Date:   Fri, 10 Nov 2023 15:18:40 +0100
From:   Maxime Ripard <mripard@...nel.org>
To:     Dipam Turkar <dipamt1729@...il.com>
Cc:     maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch, mairacanal@...eup.net,
        javierm@...hat.com, arthurgrillo@...eup.net,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tests: Add KUnit tests for
 drm_mode_create_dvi_i_properties()

Hi,

On Fri, Nov 10, 2023 at 04:33:23PM +0530, Dipam Turkar wrote:
> Introduce unit tests for the drm_mode_create_dvi_i_properties() function to ensure
> the proper creation of DVI-I specific connector properties.
> 
> Signed-off-by: Dipam Turkar <dipamt1729@...il.com>
> ---
>  drivers/gpu/drm/tests/drm_connector_test.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
> index c66aa2dc8d9d..aad63839b5e5 100644
> --- a/drivers/gpu/drm/tests/drm_connector_test.c
> +++ b/drivers/gpu/drm/tests/drm_connector_test.c
> @@ -4,6 +4,9 @@
>   */
>  
>  #include <drm/drm_connector.h>
> +#include <drm/drm_device.h>
> +#include <drm/drm_drv.h>
> +#include <drm/drm_kunit_helpers.h>
>  
>  #include <kunit/test.h>
>  
> @@ -58,10 +61,27 @@ static void drm_test_get_tv_mode_from_name_truncated(struct kunit *test)
>  	KUNIT_EXPECT_LT(test, ret, 0);
>  };
>  
> +static void drm_test_mode_create_dvi_i_properties(struct kunit *test)

You should document what this test is checking.

Probably something like:

/*
 * Test that drm_mode_create_dvi_i_properties() succeeds and have
 * created the DVI-I subconnector and select subconectors properties.
 */

> +{
> +	struct drm_device *drm;
> +	struct device *dev;
> +
> +	dev = drm_kunit_helper_alloc_device(test);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
> +
> +	drm = __drm_kunit_helper_alloc_drm_device(test, dev, sizeof(*drm), 0, DRIVER_MODESET);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm);
> +
> +	KUNIT_EXPECT_EQ(test, drm_mode_create_dvi_i_properties(drm), 0);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm->mode_config.dvi_i_select_subconnector_property);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm->mode_config.dvi_i_subconnector_property);

These two should be expectations, not assertions.

>  static struct kunit_case drm_get_tv_mode_from_name_tests[] = {
>  	KUNIT_CASE_PARAM(drm_test_get_tv_mode_from_name_valid,
>  			 drm_get_tv_mode_from_name_valid_gen_params),
>  	KUNIT_CASE(drm_test_get_tv_mode_from_name_truncated),
> +	KUNIT_CASE(drm_test_mode_create_dvi_i_properties),

This test suite is meant to test drm_get_tv_mode_from_name. Please
create a new test suite for the function you're testing.

We should also add a few more tests, like calling it twice will still
return 0 on the second attempt for example.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)