linux-kernel - Re: [PATCH net-next] packet: add a generic drop reason for receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO3-PbqSXjMrYKovoUJK5FhfD=zpkKosVbK2UtAARa0VEFzuGQ@mail.gmail.com>
Date:   Fri, 10 Nov 2023 08:48:34 -0600
From:   Yan Zhai <yan@...udflare.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Weongyo Jeong <weongyo.linux@...il.com>,
        Ivan Babrou <ivan@...udflare.com>,
        David Ahern <dsahern@...nel.org>,
        Jesper Brouer <jesper@...udflare.com>,
        linux-kernel@...r.kernel.org, kernel-team@...udflare.com
Subject: Re: [PATCH net-next] packet: add a generic drop reason for receive

On Fri, Nov 10, 2023 at 3:31 AM Eric Dumazet <edumazet@...gle.com> wrote:
> it is time we replace the various constructs which do not help readability:
>
> if (something)
>      consume_skb(skb);
> else
>      kfree_skb_reason(skb, drop_reason);
>
> By:
>
> kfree_skb_reason(skb, drop_reason);
>
> (By using drop_reason == SKB_CONSUMED when appropriate)
Will send a V2 when net-next reopens