linux-kernel - linux-6.6/tools/perf/util/bpf_map.c:50:8: style: Suspicious condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AS8PR02MB102175ECBFEE1AD4D124C9DE69CAEA@AS8PR02MB10217.eurprd02.prod.outlook.com>
Date:   Fri, 10 Nov 2023 19:07:29 +0000
From:   David Binderman <dcb314@...mail.com>
To:     "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "irogers@...gle.com" <irogers@...gle.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: linux-6.6/tools/perf/util/bpf_map.c:50:8: style: Suspicious condition

Hello there,

Static analyser cppcheck says:

linux-6.6/tools/perf/util/bpf_map.c:50:8: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

Source code is

    while ((err = bpf_map_get_next_key(fd, prev_key, key) == 0)) {

Suggest new code:

    while ((err = bpf_map_get_next_key(fd, prev_key, key)) == 0) {

Regards

David Binderman