linux-kernel - Re: [PATCH v3 13/25] i2c: designware: Drop return value from dw_i2c_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <839ed9c8-f58e-495e-97a1-0734b8fa6fb8@amd.com>
Date:   Fri, 10 Nov 2023 13:41:00 -0600
From:   Mario Limonciello <mario.limonciello@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Andi Shyti <andi.shyti@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v3 13/25] i2c: designware: Drop return value from
 dw_i2c_of_configure()

On 11/10/2023 12:11, Andy Shevchenko wrote:
> dw_i2c_of_configure() is called without checking of the returned
> value, hence just drop it by converting to void.
> 
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 15f19ec20b33..7449f1b37ecf 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -110,7 +110,7 @@ static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev)
>   	return 0;
>   }
>   
> -static int dw_i2c_of_configure(struct platform_device *pdev)
> +static void dw_i2c_of_configure(struct platform_device *pdev)
>   {
>   	struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
>   
> @@ -123,8 +123,6 @@ static int dw_i2c_of_configure(struct platform_device *pdev)
>   	default:
>   		break;
>   	}
> -
> -	return 0;
>   }
>   #else
>   static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
> @@ -132,9 +130,8 @@ static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
>   	return -ENODEV;
>   }
>   
> -static inline int dw_i2c_of_configure(struct platform_device *pdev)
> +static inline void dw_i2c_of_configure(struct platform_device *pdev)
>   {
> -	return -ENODEV;
>   }
>   #endif
>