linux-kernel - Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Nov 2023 13:38:34 -0600
From:   Mario Limonciello <mario.limonciello@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Andi Shyti <andi.shyti@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID
 tables

On 11/10/2023 12:11, Andy Shevchenko wrote:
> Make the terminator entry look the same in all device ID tables.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 +-
>   drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index db642e0aa61f..7f04dc33e6f7 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -402,7 +402,7 @@ static const struct pci_device_id i2c_designware_pci_ids[] = {
>   	{ PCI_VDEVICE(ATI,  0x73c4), navi_amd },
>   	{ PCI_VDEVICE(ATI,  0x7444), navi_amd },
>   	{ PCI_VDEVICE(ATI,  0x7464), navi_amd },
> -	{ 0,}
> +	{}
>   };
>   MODULE_DEVICE_TABLE(pci, i2c_designware_pci_ids);
>   
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 5d8427ccc9b4..018c353a456a 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -57,7 +57,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>   	{ "HISI02A2", 0 },
>   	{ "HISI02A3", 0 },
>   	{ "HYGO0010", ACCESS_INTR_MASK },
> -	{ }
> +	{}
>   };
>   MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
>   #endif
> @@ -153,7 +153,7 @@ static const struct of_device_id dw_i2c_of_match[] = {
>   	{ .compatible = "snps,designware-i2c", },
>   	{ .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT },
>   	{ .compatible = "baikal,bt1-sys-i2c", .data = (void *)MODEL_BAIKAL_BT1 },
> -	{},
> +	{}
>   };
>   MODULE_DEVICE_TABLE(of, dw_i2c_of_match);
>   #else