linux-kernel - Re: [PATCH v2 RESEND] ARM: dts: hpe: BUG: Correct GXP register ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6cce1756-db32-4486-96d0-320d08569fbf@app.fastmail.com>
Date:   Fri, 10 Nov 2023 21:33:21 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     charles.kearney@....com, "Verdun, Jean-Marie" <verdun@....com>,
        "Hawkins, Nick" <nick.hawkins@....com>,
        "Rob Herring" <robh+dt@...nel.org>,
        krzysztof.kozlowski+dt@...aro.org,
        "Conor Dooley" <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] ARM: dts: hpe: BUG: Correct GXP register ranges

On Fri, Nov 10, 2023, at 20:48, charles.kearney@....com wrote:
> -		ahb@...00000 {
> +		ahb@...00000 {
>  			compatible = "simple-bus";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges = <0x0 0xc0000000 0x30000000>;
>  			dma-ranges;
> +			ranges = <0x00000000 0x80000000 0x20000000>,
> +					 <0x40000000 0xc0000000 0x3fff0000>;
> 
> -			vic0: interrupt-controller@...0000 {
> +			vic0: interrupt-controller@...f0000 {
>  				compatible = "arm,pl192-vic";
> -				reg = <0xeff0000 0x1000>;
> +				reg = <0x4eff0000 0x1000>;
>  				interrupt-controller;
>  				#interrupt-cells = <1>;
>  			};
> 
> -			vic1: interrupt-controller@...00000 {
> +			vic1: interrupt-controller@...000 {
>  				compatible = "arm,pl192-vic";
> -				reg = <0x80f00000 0x1000>;
> +				reg = <0xf00000 0x1000>;
>  				interrupt-controller;
>  				#interrupt-cells = <1>;
>  			};
> 
> -			uarta: serial@e0 {
> +			uarta: serial@...000e0 {

Are these the actual addresses in the datasheet or
did you just make up a mapping?

If you have two separate address ranges, that would
typically indicate that there are two distinct ahb
instances that should be represented as separate
bus nodes. With the new mapping, it looks like all the
devices using vic0 are part of the same address range
as vic0, which also indicates that they might
be on one bus.

If this is a single ahb instance with multiple distinct
address ranges, I would expect that you need to adapt
the dma-ranges as well.

     Arnd