linux-kernel - Re: [PATCH 05/17] dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169964880016.393384.2296633788360305234.robh@kernel.org>
Date:   Fri, 10 Nov 2023 14:40:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
        Daniel Vetter <daniel@...ll.ch>,
        linux-arm-kernel@...ts.infradead.org,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-pwm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-sound@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Jiri Slaby <jirislaby@...nel.org>, alsa-devel@...a-project.org,
        Tomasz Figa <tomasz.figa@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-i2c@...r.kernel.org,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-serial@...r.kernel.org, David Airlie <airlied@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Conor Dooley <conor+dt@...nel.org>, linux-rtc@...r.kernel.org,
        Lee Jones <lee@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH 05/17] dt-bindings: pinctrl: samsung: add specific
 compatibles for existing SoC


On Wed, 08 Nov 2023 11:43:31 +0100, Krzysztof Kozlowski wrote:
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine
> and there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like
> compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
> ---
>  .../samsung,pinctrl-wakeup-interrupt.yaml     | 24 ++++++++++++-------
>  .../bindings/pinctrl/samsung,pinctrl.yaml     |  3 ++-
>  2 files changed, 17 insertions(+), 10 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>