linux-kernel - Re: [PATCH v2 2/7] fs/proc/page: use a folio in stable_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZU5zRk+yi74pmAsq@casper.infradead.org>
Date:   Fri, 10 Nov 2023 18:15:34 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        David Hildenbrand <david@...hat.com>,
        Gregory Price <gregory.price@...verge.com>
Subject: Re: [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags()

On Fri, Nov 10, 2023 at 11:33:19AM +0800, Kefeng Wang wrote:
> Replace nine compound_head() calls with one page_folio().

But that's not all it does.  Honestly, when you write these kind of
things, I wonder if you understand what you're doing.

After this patch, if we report on a tail page, we set (some of) the
flags according to how its head page is set.  Before, we would have not
reported on it at all.

This was THE ENTIRE POINT of Greg's patch.  And why his patch made sense
and yours is nonsense.  Andrew, please drop this patch series.