linux-kernel - Re: [PATCH next V3] proc: support file->f_pos checking in mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231110082111.GN1957730@ZenIV>
Date:   Fri, 10 Nov 2023 08:21:11 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Zizhi Wo <wozizhi@...wei.com>
Cc:     brauner@...nel.org, akpm@...ux-foundation.org, oleg@...hat.com,
        jlayton@...nel.org, dchinner@...hat.com, adobriyan@...il.com,
        yang.lee@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, yangerkun@...wei.com
Subject: Re: [PATCH next V3] proc: support file->f_pos checking in mem_lseek

On Fri, Nov 10, 2023 at 11:19:28PM +0800, Zizhi Wo wrote:
> From: WoZ1zh1 <wozizhi@...wei.com>
> 
> In mem_lseek, file->f_pos may overflow. And it's not a problem that
> mem_open set file mode with FMODE_UNSIGNED_OFFSET(memory_lseek). However,
> another file use mem_lseek do lseek can have not FMODE_UNSIGNED_OFFSET
> (kpageflags_proc_ops/proc_pagemap_operations...), so in order to prevent
> file->f_pos updated to an abnormal number, fix it by checking overflow and
> FMODE_UNSIGNED_OFFSET.

1) How is that different from the previous version?
2) Would FMODE_UNSIGNED_OFFSET be wrong for those files?  If not, why not?