linux-kernel - Re: [PATCH 4/4] media: rkvdec: Hook the (TRY_)DECODER_CMD stateless ioctls

Open Source and information security mailing list archives

Date:   Fri, 10 Nov 2023 21:08:27 +0000
From:   "Daniel Almeida" <daniel.almeida@...labora.com>
To:     "Paul Kocialkowski" <paul.kocialkowski@...tlin.com>
Cc:     linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        "Ezequiel Garcia" <ezequiel@...guardiasur.com.ar>,
        "Philipp Zabel" <p.zabel@...gutronix.de>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Hans Verkuil" <hverkuil-cisco@...all.nl>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Nicolas Dufresne" <nicolas.dufresne@...labora.com>,
        "Sebastian Fricke" <sebastian.fricke@...labora.com>,
        "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 4/4] media: rkvdec: 
 Hook the (TRY_)DECODER_CMD stateless ioctls

On Thursday, November 09, 2023 17:16 -03, Paul Kocialkowski <paul.kocialkowski@...tlin.com> wrote:

> The (TRY_)DECODER_CMD ioctls are used to support flushing when holding capture
> buffers is supported. This is the case of this driver but the ioctls were never
> hooked to the ioctl ops.
> 
> Add them to correctly support flushing.
> 
> Fixes: ed7bb87d3d03 ("media: rkvdec: Enable capture buffer holding for H264")
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> ---
>  drivers/staging/media/rkvdec/rkvdec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 84a41792cb4b..ac398b5a9736 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -461,6 +461,9 @@ static const struct v4l2_ioctl_ops rkvdec_ioctl_ops = {
>  
>  	.vidioc_streamon = v4l2_m2m_ioctl_streamon,
>  	.vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
> +
> +	.vidioc_decoder_cmd = v4l2_m2m_ioctl_stateless_decoder_cmd,
> +	.vidioc_try_decoder_cmd = v4l2_m2m_ioctl_stateless_try_decoder_cmd,
>  };
>  
>  static int rkvdec_queue_setup(struct vb2_queue *vq, unsigned int *num_buffers,
> -- 
> 2.42.1
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives