linux-kernel - Re: [PATCH 01/41] rxrpc: Fix RTT determination to use PING ACKs as a source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33913a7e-9bac-4812-964f-7efe305b50aa@auristor.com>
Date:   Fri, 10 Nov 2023 16:54:46 -0500
From:   Jeffrey E Altman <jaltman@...istor.com>
To:     David Howells <dhowells@...hat.com>
Cc:     Marc Dionne <marc.dionne@...istor.com>,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/41] rxrpc: Fix RTT determination to use PING ACKs as a
 source

On 11/10/2023 12:25 PM, David Howells wrote:
> Jeffrey E Altman<jaltman@...istor.com>  wrote:
>
>>> I do ignore ack.serial == 0 for this purpose.
>> Zero has the special meaning - this ACK is not explicitly in response to a
>> received packet.
>>
>> However, as mentioned, the serial number counter wraps frequently and most
>> RxRPC implementations
>> do not transition from serial 0xffffffff -> 0x00000001 when wrapping.
> I don't skip zero serial numbers either.  I'm not sure whether it would be
> better to do so.

If a DATA packet is sent with serial number zero and an ACK packet is 
sent in response to it
with the ack.serial field set to the DATA packet serial number (zero), 
then the receiver of the
ACK will be unable to compute an RTT from that DATA packet.   It will 
happen rarely but it
will happen.

Jeffrey


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4039 bytes)